Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP - Fix import errors for types with similar names but different namespaces in request builders #3425

Merged
merged 5 commits into from
Oct 5, 2023
Merged

PHP - Fix import errors for types with similar names but different namespaces in request builders #3425

merged 5 commits into from
Oct 5, 2023

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Oct 4, 2023

This PR:

  • Writes fully qualified name for duplicated symbols in request executor
  • Updates integration test suppressions

@Ndiritu Ndiritu added the PHP label Oct 4, 2023
@Ndiritu Ndiritu added this to the Kiota v1.7 milestone Oct 4, 2023
@Ndiritu Ndiritu self-assigned this Oct 4, 2023
@Ndiritu Ndiritu changed the title PHP - Fix missing types in request builder PHP - Fix import errors for same types with different namespaces in request builders Oct 4, 2023
@Ndiritu Ndiritu force-pushed the fix/php-missing-imports branch from 5a41f98 to be296bd Compare October 4, 2023 18:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Ndiritu Ndiritu changed the title PHP - Fix import errors for same types with different namespaces in request builders PHP - Fix import errors for types with similar names but different namespaces in request builders Oct 4, 2023
@Ndiritu Ndiritu marked this pull request as ready for review October 4, 2023 18:31
@Ndiritu Ndiritu requested a review from a team as a code owner October 4, 2023 18:31
@Ndiritu Ndiritu merged commit a5c6afe into main Oct 5, 2023
173 checks passed
@Ndiritu Ndiritu deleted the fix/php-missing-imports branch October 5, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@Ndiritu Ndiritu

Labels
PHP
Projects
None yet
Milestone
Kiota v1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@Ndiritu @andrueastman